Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly make certain internal traces private #837

Merged
merged 1 commit into from
May 13, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented May 12, 2024

Goal

Make diagnostic traces explicitly private

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

@bidetofevil bidetofevil marked this pull request as ready for review May 12, 2024 20:48
@bidetofevil bidetofevil requested a review from a team as a code owner May 12, 2024 20:48
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (4ad54a8) to head (8d9112e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   80.99%   81.00%           
=======================================
  Files         426      426           
  Lines       11414    11417    +3     
  Branches     1690     1690           
=======================================
+ Hits         9245     9248    +3     
  Misses       1458     1458           
  Partials      711      711           
Files Coverage Δ
...d/embracesdk/capture/startup/StartupServiceImpl.kt 100.00% <100.00%> (ø)
...oid/embracesdk/injection/ModuleInitBootstrapper.kt 91.10% <100.00%> (+0.06%) ⬆️

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil merged commit c27f6bc into master May 13, 2024
4 checks passed
@bidetofevil bidetofevil deleted the hho/private-traces branch May 13, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants