Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback behavior for 4xx and 5xx status code. #82

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

lucaslabari
Copy link
Contributor

Goal

  • In this PR we introduced some changes on the behavior when 4xx and 5xx status code is received.
  • The change on that PR was not to retry when receiving those status codes because they are not expected to succeed on a retry.
  • We are now rolling back that change because 2 functional tests failed and we plan to reintroduce these changes soon.

Testing

Covered by existing tests.

@lucaslabari lucaslabari requested a review from a team as a code owner November 16, 2023 17:17
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #82 (e596d22) into master (4c5ff31) will increase coverage by 0.07%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   75.92%   75.99%   +0.07%     
==========================================
  Files         313      313              
  Lines       10114    10104      -10     
  Branches     1461     1455       -6     
==========================================
  Hits         7679     7679              
+ Misses       1843     1833      -10     
  Partials      592      592              
Files Coverage Δ
.../android/embracesdk/comms/api/EmbraceApiService.kt 77.64% <33.33%> (+8.17%) ⬆️

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider just adding throws to the failure and payloadTooLarge blocks instead as the current behaviour doesn't throw if we get a 304 (even though the server doesn't return that right now I don't think for posts)

@lucaslabari lucaslabari merged commit 901d327 into master Nov 16, 2023
3 of 4 checks passed
@lucaslabari lucaslabari deleted the lucas/rollback_4xx_status_code_behavior branch November 16, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants