Filter private logs out of external exporters #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandro-godon
commented
Apr 29, 2024
| @@ -40,6 +42,10 @@ internal class LogWriterImpl( | |||
| builder.setAttribute(embState.attributeKey, appState) | |||
| } | |||
|
|
|||
| if (isPrivate) { | |||
| builder.setFixedAttribute(PrivateSpan) | |||
There was a problem hiding this comment.
We may want to rename PrivateSpan to Private to avoid confusion here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
==========================================
+ Coverage 81.15% 81.21% +0.06%
==========================================
Files 426 426
Lines 11334 11346 +12
Branches 1686 1688 +2
==========================================
+ Hits 9198 9215 +17
+ Misses 1422 1417 -5
Partials 714 714
|
nelsitoPuglisi
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Filter out OTel logs with the "emb.private" attribute when exporting to a customer-provided log exporter.
Testing
Modified unit tests. Note that currently there are no logs that are marked as private within the SDK.