Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract session ordinal logic to preference service #81

Merged
merged 1 commit into from
Nov 17, 2023

refactor: extract session ordinal logic to pref services

60f1de2
Select commit
Loading
Failed to load commit list.
Merged

Extract session ordinal logic to preference service #81

refactor: extract session ordinal logic to pref services
60f1de2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 17, 2023 in 0s

76.02% (-0.01%) compared to 8cfc0f0

View this Pull Request on Codecov

76.02% (-0.01%) compared to 8cfc0f0

Details

Codecov Report

Merging #81 (60f1de2) into master (8cfc0f0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   76.03%   76.02%   -0.01%     
==========================================
  Files         313      313              
  Lines       10097    10095       -2     
  Branches     1455     1455              
==========================================
- Hits         7677     7675       -2     
  Misses       1832     1832              
  Partials      588      588              
Files Coverage Δ
...roid/embracesdk/prefs/EmbracePreferencesService.kt 90.14% <100.00%> (+0.06%) ⬆️
...ace/android/embracesdk/prefs/PreferencesService.kt 0.00% <ø> (ø)
...brace/android/embracesdk/session/SessionHandler.kt 87.71% <100.00%> (-0.22%) ⬇️