Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move session enum and session properties #80

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Moves an enum out of the SessionHandler class & also avoids unnecessary passing of the sessionProperties as a function parameter.

Testing

Updated existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner November 16, 2023 14:43
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #80 (12ea063) into master (4cdfd20) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   76.02%   76.02%   -0.01%     
==========================================
  Files         313      314       +1     
  Lines       10079    10076       -3     
  Branches     1457     1457              
==========================================
- Hits         7663     7660       -3     
  Misses       1827     1827              
  Partials      589      589              
Files Coverage Δ
...race/android/embracesdk/injection/SessionModule.kt 100.00% <100.00%> (ø)
...ndroid/embracesdk/session/EmbraceSessionService.kt 81.33% <100.00%> (-0.72%) ⬇️
...brace/android/embracesdk/session/SessionHandler.kt 88.53% <ø> (-0.49%) ⬇️
.../android/embracesdk/session/SessionSnapshotType.kt 100.00% <100.00%> (ø)

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah. Love to see unused dependancies ripped out!

Base automatically changed from refine-session-end-logic to master November 17, 2023 11:29
@fractalwrench fractalwrench merged commit 7b2e011 into master Nov 17, 2023
3 checks passed
@fractalwrench fractalwrench deleted the refactor-code-org branch November 17, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants