NetworkStatusDataSource #775
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @nelsitoPuglisi and the rest of your teammates on |
nelsitoPuglisi
force-pushed
the
nelson/network-status-data-source
branch
from
1231352
to
1f07821
Compare
| @@ -96,85 +95,6 @@ internal class EmbraceNetworkConnectivityServiceTest { | |||
| verify { context.unregisterReceiver(service) } | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Do we have equivalent tests for the data source or are these functionality implemented by the infra the data source builds on?
There was a problem hiding this comment.
So, the new data source doesn't care about the actual network status or connection type. I can write a new set of unit tests to verify that each type is returned properly by EmbraceNetworkConnectivityService but I don't see much value there TBH.
There was a problem hiding this comment.
LGTM. One question about the unit tests - and if there's anything @fractalwrench wants to explicitly look at, feel free to wait for him. But looks good to me
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
==========================================
- Coverage 81.42% 81.40% -0.02%
==========================================
Files 431 432 +1
Lines 11357 11375 +18
Branches 1693 1691 -2
==========================================
+ Hits 9247 9260 +13
- Misses 1390 1395 +5
Partials 720 720
|
Goal
The goal is to capture network connectivity changes as network status spans, instead of network status breadcrumb
Testing
Unit, integration and manual