Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel network request capture #768

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Conversation

leandro-godon
Copy link
Contributor

@leandro-godon leandro-godon commented Apr 18, 2024

Goal

Send captured network requests as otel logs instead of events.

Testing

Tested against the mock API. Verified that the data reaches Kafka.

@leandro-godon leandro-godon requested a review from a team as a code owner April 18, 2024 15:56
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.53%. Comparing base (838bbae) to head (75930ff).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   81.59%   81.53%   -0.07%     
==========================================
  Files         429      430       +1     
  Lines       11372    11419      +47     
  Branches     1701     1704       +3     
==========================================
+ Hits         9279     9310      +31     
- Misses       1369     1382      +13     
- Partials      724      727       +3     
Files Coverage Δ
.../embrace/android/embracesdk/arch/schema/EmbType.kt 84.61% <100.00%> (+0.40%) ⬆️
...brace/android/embracesdk/arch/schema/SchemaType.kt 72.46% <100.00%> (+5.79%) ⬆️
...dk/network/logging/NetworkCaptureDataSourceImpl.kt 100.00% <100.00%> (ø)
...id/embracesdk/internal/logs/CompositeLogService.kt 96.72% <75.00%> (+0.16%) ⬆️
.../android/embracesdk/injection/CustomerLogModule.kt 94.64% <40.00%> (-5.36%) ⬇️

... and 15 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One comment about whether we can just not support a null object to pass to the data source but if we can't, no big deal.

We'll finalize the attribute names later and since the backend doesn't use them yet, this is totally fine.

@leandro-godon leandro-godon merged commit 9312e15 into master Apr 18, 2024
4 checks passed
@leandro-godon leandro-godon deleted the leandro/otel_network_body_capture branch April 18, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants