Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel logs integration test #751

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Conversation

leandro-godon
Copy link
Contributor

Goal

Copy the tests in LogginApiTest but using the OTel logs instead.

@leandro-godon leandro-godon requested a review from a team as a code owner April 17, 2024 15:54
@Rule
@JvmField
val testRule: IntegrationTestRule = IntegrationTestRule {
val clock = FakeClock(IntegrationTestRule.DEFAULT_SDK_START_TIME_MS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, I need to make the overriding of this better so you don't have to do this....

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	embrace-android-sdk/src/integrationTest/kotlin/io/embrace/android/embracesdk/IntegrationTestRuleExtensions.kt
@leandro-godon leandro-godon merged commit 247ff28 into master Apr 17, 2024
2 checks passed
@leandro-godon leandro-godon deleted the leandro/log_integration_test branch April 17, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants