Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace emb.state with android.state #713

Closed

Conversation

lucaslabari
Copy link
Contributor

Goal

  • Replaced emb.state with android.state that is what the Opentelemetry documentation specifies that should be used.

Testing

Rely on existing unit tests.

@lucaslabari lucaslabari requested a review from a team as a code owner April 12, 2024 21:51
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.40%. Comparing base (17a1489) to head (1e8cfbb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   80.39%   80.40%           
=======================================
  Files         426      426           
  Lines       11258    11258           
  Branches     1703     1703           
=======================================
+ Hits         9051     9052    +1     
  Misses       1486     1486           
+ Partials      721      720    -1     
Files Coverage Δ
...d/embracesdk/opentelemetry/EmbraceAttributeKeys.kt 100.00% <ø> (ø)
...acesdk/opentelemetry/OpenTelemetryAttributeKeys.kt 100.00% <100.00%> (ø)
...roid/embracesdk/internal/logs/EmbraceLogService.kt 91.22% <0.00%> (ø)

... and 1 file with indirect coverage changes

@lucaslabari
Copy link
Contributor Author

I just talked with backend and iOS and we agree on not using it yet. They argued that we are considering just 2 states instead of all the possible states defined in the Opentelemetry documentation.
Let's postpone the discussion and make the change once all platforms are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants