addLogRecordExporter api #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsitoPuglisi
force-pushed
the
nelson/otel-exporter-log-record
branch
from
69e092a
to
0df22ad
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @nelsitoPuglisi and the rest of your teammates on |
nelsitoPuglisi
force-pushed
the
nelson/otel-exporter-log-record
branch
from
0df22ad
to
bd70be7
Compare
nelsitoPuglisi
force-pushed
the
nelson/otel-exporter-log-record
branch
from
bd70be7
to
b614e2f
Compare
nelsitoPuglisi
requested review from
fractalwrench,
fnewberg,
bidetofevil and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 81.45% 81.52% +0.07%
==========================================
Files 432 432
Lines 11375 11374 -1
Branches 1692 1693 +1
==========================================
+ Hits 9265 9273 +8
+ Misses 1389 1384 -5
+ Partials 721 717 -4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds a public api that allows a client app to add a LogRecordExporter at runtime, through a OpenTelemetryConfiguration class.
Testing
Added instrumentation tests to LogsTest class.
Release Notes
New addLogRecordExporter public api, to add many LogRecordExporter to the OTel SDK.
WHAT:We have created an api to add LogRecordExporter to the OTel SDK
WHY:To allow customers to export their data to any OTel Collector.
WHO:Any customer with an OTel collector.