Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functional tests after session span and sequence_id privacy changes #689

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Apr 10, 2024

Goal

Fix for functional test failures caused by two unrelated changes

I will be overridding merge rules and merging when it passes CI as this is a test fix.

@bidetofevil bidetofevil requested a review from a team as a code owner April 10, 2024 21:38
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.96%. Comparing base (14dc0be) to head (d2e7c03).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   79.95%   79.96%   +0.01%     
==========================================
  Files         422      422              
  Lines       11143    11143              
  Branches     1685     1685              
==========================================
+ Hits         8909     8911       +2     
+ Misses       1538     1535       -3     
- Partials      696      697       +1     

see 3 files with indirect coverage changes

@bidetofevil bidetofevil merged commit d88be4c into master Apr 10, 2024
4 checks passed
@bidetofevil bidetofevil deleted the hho/fix-f-test-after-privacy branch April 10, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant