TapBreadcrumbDataSource created

[nelsitoPuglisi]

Goal

Create a TapBreadcrumbDataSource to log taps as span events.

Testing

Unit test

[nelsitoPuglisi]

• user TapBreadcrumbDataSource in the session message #665
• TapBreadcrumbDataSource created #663 👈
• replace android.util.Pair #662
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nelsitoPuglisi and the rest of your teammates on Graphite

[bidetofevil]

Not for the migration now, but something to think about for the future when we want to make this a semantic convention for all of OTel - do we want to have a "unit" field so tap coordinates can be in % of the viewport, device pixels, device independent pixels, etc?

[bidetofevil]

Looks good. I assume the integration tests be added in a separate PR?

[nelsitoPuglisi]

Looks good. I assume the integration tests be added in a separate PR?

Yes, there are part of the next PR, when it's hooked up in the breadcrumb service.

[codecov]

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 80.22%. Comparing base (12db875) to head (a45dde4).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   80.21%   80.22%           
=======================================
  Files         418      419    +1     
  Lines       10960    10998   +38     
  Branches     1661     1665    +4     
=======================================
+ Hits         8792     8823   +31     
- Misses       1491     1494    +3     
- Partials      677      681    +4     

Files	Coverage Δ
.../embrace/android/embracesdk/arch/schema/EmbType.kt	85.71% <100.00%> (+1.09%)	⬆️
...racesdk/capture/crumbs/EmbraceBreadcrumbService.kt	96.42% <100.00%> (ø)
...dk/capture/crumbs/LegacyTapBreadcrumbDataSource.kt	54.54% <100.00%> (ø)
...mbrace/android/embracesdk/payload/TapBreadcrumb.kt	87.50% <100.00%> (+2.88%)	⬆️
...brace/android/embracesdk/arch/schema/SchemaType.kt	95.23% <90.00%> (-1.64%)	⬇️
...android/embracesdk/capture/crumbs/TapDataSource.kt	70.83% <70.83%> (ø)

... and 3 files with indirect coverage changes