Stop setting KVM group permissions on CI job #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 75.99% 75.99%
=======================================
Files 309 309
Lines 10057 10058 +1
Branches 1448 1448
=======================================
+ Hits 7643 7644 +1
Misses 1826 1826
Partials 588 588
|
lucaslabari
approved these changes
Nov 14, 2023
vitaliyf
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
CI is intermittently failing because some machines don't have KVM installed.
We don't actually use KVM in the one job where it is enabled because there isn't any step that loads an emulator. Therefore it should be safe to remove this & prevent CI failing intermittently.