Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add low memory warnings as span events #653

Closed
wants to merge 4 commits into from

Conversation

leandro-godon
Copy link
Contributor

Goal

Report low memory warnings as span events. The previous collection method has not been removed, so warnings are also sent in the mw key of the PerformanceInfo payload.

Testing

Tested generating a memory warning on a device and observing the span event in the mock api.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.18%. Comparing base (4f3bb3c) to head (8d712de).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   80.16%   80.18%   +0.02%     
==========================================
  Files         417      418       +1     
  Lines       11343    11370      +27     
  Branches     1680     1680              
==========================================
+ Hits         9093     9117      +24     
- Misses       1577     1580       +3     
  Partials      673      673              
Files Coverage Δ
.../embrace/android/embracesdk/arch/schema/EmbType.kt 85.71% <100.00%> (+1.09%) ⬆️
...brace/android/embracesdk/arch/schema/SchemaType.kt 97.14% <100.00%> (+0.36%) ⬆️
.../embracesdk/capture/memory/EmbraceMemoryService.kt 100.00% <100.00%> (ø)
...bracesdk/capture/memory/MemoryWarningDataSource.kt 100.00% <100.00%> (ø)
...d/embracesdk/injection/DataCaptureServiceModule.kt 100.00% <100.00%> (ø)
...e/android/embracesdk/injection/DataSourceModule.kt 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@leandro-godon leandro-godon deleted the leandro/enable_otel_memory_warning branch May 8, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant