Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach TelemetryType from SchemaType #634

Closed
wants to merge 1 commit into from

Conversation

bidetofevil
Copy link
Collaborator

Goal

Testing

Release Notes

WHAT:

WHY:

WHO:

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.32%. Comparing base (b4d037f) to head (1c2d2d5).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
+ Coverage   80.30%   80.32%   +0.02%     
==========================================
  Files         417      418       +1     
  Lines       11337    11336       -1     
  Branches     1678     1678              
==========================================
+ Hits         9104     9106       +2     
+ Misses       1554     1551       -3     
  Partials      679      679              
Files Coverage Δ
...ndroid/embracesdk/arch/destination/LogEventData.kt 100.00% <100.00%> (ø)
...droid/embracesdk/arch/destination/SpanEventData.kt 100.00% <100.00%> (ø)
...droid/embracesdk/arch/destination/StartSpanData.kt 66.66% <100.00%> (-8.34%) ⬇️
...droid/embracesdk/arch/destination/TelemetryData.kt 100.00% <100.00%> (ø)
...brace/android/embracesdk/arch/schema/SchemaType.kt 96.15% <ø> (-0.63%) ⬇️
...ndroid/embracesdk/capture/aei/AeiDataSourceImpl.kt 77.61% <100.00%> (+0.16%) ⬆️
...cesdk/capture/crumbs/CustomBreadcrumbDataSource.kt 92.85% <100.00%> (+0.54%) ⬆️
...sdk/capture/crumbs/FragmentBreadcrumbDataSource.kt 64.28% <100.00%> (+1.32%) ⬆️
...roid/embracesdk/internal/logs/EmbraceLogService.kt 92.30% <100.00%> (+0.09%) ⬆️
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt 91.30% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant