Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add span_snapshot to session-end.json #614

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented Mar 21, 2024

Goal

Fix functional tests: sessionEndMessageTest() is failing

  • expecting s.span_snapshots as array
  • expecting br.vb.en View Breadcrumb end time (?)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nelsitoPuglisi and the rest of your teammates on Graphite Graphite

@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review March 21, 2024 20:24
@nelsitoPuglisi nelsitoPuglisi requested a review from a team as a code owner March 21, 2024 20:24
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (4f380a8) to head (6334294).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   80.50%   80.49%   -0.01%     
==========================================
  Files         415      415              
  Lines       11149    11149              
  Branches     1640     1640              
==========================================
- Hits         8975     8974       -1     
- Misses       1515     1516       +1     
  Partials      659      659              

see 2 files with indirect coverage changes

@nelsitoPuglisi nelsitoPuglisi merged commit f1752cf into master Mar 22, 2024
4 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/fix-functional-tests branch March 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants