Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common interface from LogService and LogMessageService #599

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

leandro-godon
Copy link
Contributor

Goal

Extract methods from LogMessageService and LogService to a shared interface to make it easier to switch between them based on a feature flag.

@leandro-godon leandro-godon requested a review from a team as a code owner March 19, 2024 12:40
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.44%. Comparing base (c2b4ace) to head (edf4662).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   80.42%   80.44%   +0.02%     
==========================================
  Files         412      412              
  Lines       11083    11087       +4     
  Branches     1637     1638       +1     
==========================================
+ Hits         8913     8919       +6     
+ Misses       1517     1516       -1     
+ Partials      653      652       -1     
Files Coverage Δ
...roid/embracesdk/internal/logs/EmbraceLogService.kt 92.20% <100.00%> (+0.31%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if there is a chance to unify LogService and LogMessageService interfaces both into BaseLogService.
We can do it in another PR if the code is not ready for that yet.

@leandro-godon leandro-godon merged commit 6381d1d into master Mar 19, 2024
4 checks passed
@leandro-godon leandro-godon deleted the leandro/base_logs_interface branch March 19, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants