Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app framework value to v2 logs #594

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

leandro-godon
Copy link
Contributor

Goal

Add the "app framework" attribute for logs that was missing.

@leandro-godon leandro-godon requested a review from a team as a code owner March 18, 2024 21:14
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.44%. Comparing base (09d9a42) to head (5a9813b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   80.44%   80.44%           
=======================================
  Files         412      412           
  Lines       11072    11074    +2     
  Branches     1633     1633           
=======================================
+ Hits         8907     8909    +2     
  Misses       1514     1514           
  Partials      651      651           
Files Coverage Δ
...d/embracesdk/internal/logs/EmbraceLogAttributes.kt 87.50% <100.00%> (+0.83%) ⬆️
...roid/embracesdk/internal/logs/EmbraceLogService.kt 91.89% <100.00%> (+0.11%) ⬆️

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandro-godon leandro-godon merged commit c2b4ace into master Mar 19, 2024
4 checks passed
@leandro-godon leandro-godon deleted the leandro/logs_add_framework branch March 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants