Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some inconsistencies/bug with internal api #571

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

nelsitoPuglisi
Copy link
Contributor

Goal

Some internal API where writing the preferences service directly, instead of storing the value in-memory using metadata service.

Testing

Added some integration test to verify that still the preferences service is used when there is no value.

@nelsitoPuglisi nelsitoPuglisi requested a review from a team as a code owner March 14, 2024 23:25
@nelsitoPuglisi nelsitoPuglisi marked this pull request as draft March 14, 2024 23:25
@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review March 14, 2024 23:47
@nelsitoPuglisi nelsitoPuglisi marked this pull request as draft March 14, 2024 23:49
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.28%. Comparing base (457e4ee) to head (65715d6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   80.08%   80.28%   +0.19%     
==========================================
  Files         410      410              
  Lines       11048    11060      +12     
  Branches     1626     1627       +1     
==========================================
+ Hits         8848     8879      +31     
+ Misses       1549     1530      -19     
  Partials      651      651              
Files Coverage Δ
...race/android/embracesdk/InternalInterfaceModule.kt 100.00% <100.00%> (ø)
...e/android/embracesdk/UnityInternalInterfaceImpl.kt 58.22% <100.00%> (ø)
...racesdk/capture/metadata/EmbraceMetadataService.kt 89.89% <100.00%> (+2.03%) ⬆️
...oid/embracesdk/capture/metadata/MetadataService.kt 100.00% <ø> (ø)
...oid/embracesdk/ReactNativeInternalInterfaceImpl.kt 64.44% <60.00%> (+2.22%) ⬆️

... and 3 files with indirect coverage changes

@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review March 15, 2024 00:17
Copy link
Collaborator

LGTM. I want to refactor this so you don't have to pass the framework into the constructor and just use start(), but that'll be for later

@nelsitoPuglisi nelsitoPuglisi merged commit 5dccda4 into master Mar 15, 2024
4 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/hosted-internal-api branch March 15, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants