Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate EmbraceLogRecordData class #569

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

leandro-godon
Copy link
Contributor

Goal

Remove EmbraceLogRecordData and EmbraceLogBody and use the payload classes instead.

@leandro-godon leandro-godon requested a review from a team as a code owner March 14, 2024 19:07
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.14%. Comparing base (2d6036d) to head (cac2d16).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage   80.14%   80.14%   -0.01%     
==========================================
  Files         412      410       -2     
  Lines       11066    11048      -18     
  Branches     1626     1626              
==========================================
- Hits         8869     8854      -15     
+ Misses       1546     1543       -3     
  Partials      651      651              
Files Coverage Δ
...cesdk/capture/envelope/log/LogPayloadSourceImpl.kt 100.00% <100.00%> (ø)
...ndroid/embracesdk/internal/logs/LogOrchestrator.kt 91.66% <100.00%> (ø)
...mbrace/android/embracesdk/internal/logs/LogSink.kt 100.00% <100.00%> (ø)
...ce/android/embracesdk/internal/logs/LogSinkImpl.kt 89.47% <100.00%> (ø)
...e/android/embracesdk/internal/payload/LogMapper.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a comment.

@leandro-godon leandro-godon merged commit 457e4ee into master Mar 14, 2024
4 checks passed
@leandro-godon leandro-godon deleted the leandro/remove_duplicate_log_classes branch March 14, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants