Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to create v2 collator from module #558

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds the ability to create a v2 payload collator in the modules. This is not hooked up to production code yet - that will come in a future PR.

Testing

Updated unit tests.

@fractalwrench fractalwrench requested a review from a team as a code owner March 13, 2024 14:19
Copy link
Contributor

@leandro-godon leandro-godon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.24%. Comparing base (f88ca2d) to head (4768398).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           new-collator     #558   +/-   ##
=============================================
  Coverage         80.24%   80.24%           
=============================================
  Files               413      413           
  Lines             11014    11022    +8     
  Branches           1618     1618           
=============================================
+ Hits               8838     8845    +7     
  Misses             1532     1532           
- Partials            644      645    +1     
Files Coverage Δ
...oid/embracesdk/injection/ModuleInitBootstrapper.kt 94.67% <100.00%> (+0.02%) ⬆️
...race/android/embracesdk/injection/SessionModule.kt 100.00% <100.00%> (ø)
...d/embracesdk/session/message/PayloadFactoryImpl.kt 92.77% <100.00%> (ø)

... and 1 file with indirect coverage changes

Base automatically changed from new-collator to master March 14, 2024 06:46
@fractalwrench fractalwrench merged commit 169a8bb into master Mar 14, 2024
3 checks passed
@fractalwrench fractalwrench deleted the collator-module branch March 14, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants