Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate fields from new payload #557

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Populate fields from new payload #557

merged 1 commit into from
Mar 14, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Populates the SessionMessage with fields from the new payload. This is not hooked up yet so won't send any changes to our production API.

Testing

Added unit test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner March 13, 2024 13:18
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.24%. Comparing base (8210d0d) to head (f88ca2d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   80.20%   80.24%   +0.04%     
==========================================
  Files         413      413              
  Lines       11000    11014      +14     
  Branches     1618     1618              
==========================================
+ Hits         8822     8838      +16     
  Misses       1532     1532              
+ Partials      646      644       -2     
Files Coverage Δ
...bracesdk/capture/envelope/SessionEnvelopeSource.kt 100.00% <100.00%> (ø)
...brace/android/embracesdk/payload/SessionMessage.kt 100.00% <100.00%> (ø)
.../embracesdk/session/message/FinalEnvelopeParams.kt 88.37% <100.00%> (+0.56%) ⬆️
...d/embracesdk/session/message/PayloadFactoryImpl.kt 92.77% <100.00%> (+0.27%) ⬆️
...acesdk/session/message/V2PayloadMessageCollator.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit e65cb6d into master Mar 14, 2024
4 checks passed
@fractalwrench fractalwrench deleted the new-collator branch March 14, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants