Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V2 payload message collator #556

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Add V2 payload message collator #556

merged 1 commit into from
Mar 13, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds the skeleton of a V2 payload message collator. Currently this just calls into the v1 collator but will be updated in a future changeset to populate the new fields.

Testing

Reused test coverage from old collator.

@fractalwrench fractalwrench requested a review from a team as a code owner March 13, 2024 11:33
Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.19%. Comparing base (cce78c5) to head (2ffc51f).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           add-new-fields     #556      +/-   ##
==================================================
+ Coverage           80.16%   80.19%   +0.03%     
==================================================
  Files                 412      413       +1     
  Lines               10995    10999       +4     
  Branches             1618     1618              
==================================================
+ Hits                 8814     8821       +7     
+ Misses               1535     1532       -3     
  Partials              646      646              
Files Coverage Δ
...race/android/embracesdk/injection/SessionModule.kt 100.00% <100.00%> (ø)
...acesdk/session/message/V1PayloadMessageCollator.kt 95.40% <100.00%> (ø)
...acesdk/session/message/V2PayloadMessageCollator.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Base automatically changed from add-new-fields to master March 13, 2024 12:59
@fractalwrench fractalwrench merged commit 34af6df into master Mar 13, 2024
3 checks passed
@fractalwrench fractalwrench deleted the add-new-collator branch March 13, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants