Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new fields to SessionMessage class #555

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds new fields to the SessionMessage class. This will allow us to send the new style payload whilst maintaining backwards compatibility with the existing payload.

Testing

Added test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner March 13, 2024 10:34
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (2f6c705) to head (cce78c5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   80.11%   80.16%   +0.04%     
==========================================
  Files         412      412              
  Lines       10989    10995       +6     
  Branches     1617     1618       +1     
==========================================
+ Hits         8804     8814      +10     
+ Misses       1538     1535       -3     
+ Partials      647      646       -1     
Files Coverage Δ
...brace/android/embracesdk/payload/SessionMessage.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 6c44166 into master Mar 13, 2024
4 checks passed
@fractalwrench fractalwrench deleted the add-new-fields branch March 13, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants