Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface for payload message collator #551

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Extracts an interface from the PayloadMessageCollator class. This will allow creation of fakes in tests & also is a precursor refactoring that will enable the creation of the new payload.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner March 12, 2024 15:33
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 98.86364% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.16%. Comparing base (3b868d3) to head (7d8717f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   80.17%   80.16%   -0.01%     
==========================================
  Files         412      412              
  Lines       10986    10986              
  Branches     1617     1617              
==========================================
- Hits         8808     8807       -1     
  Misses       1535     1535              
- Partials      643      644       +1     
Files Coverage Δ
...race/android/embracesdk/injection/SessionModule.kt 100.00% <100.00%> (ø)
...esdk/session/message/PayloadMessageCollatorImpl.kt 98.85% <98.85%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit a24c482 into master Mar 13, 2024
4 checks passed
@fractalwrench fractalwrench deleted the add-interface-collator branch March 13, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants