Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter signatures on PayloadFactory class #550

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Alters the PayloadFactory interface so that callers don't need to know whether a session/background activity is being constructed. This is done by passing the process state, and having the implementation call the appropriate function. This refactor will make it easier to switch over to using the new payload.

Testing

Relied on existing unit test coverage for the session orchestrator.

@fractalwrench fractalwrench requested a review from a team as a code owner March 12, 2024 12:05
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 84.78261% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 80.12%. Comparing base (84ff699) to head (920c38d).

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           create-payload-module     #550      +/-   ##
=========================================================
- Coverage                  80.12%   80.12%   -0.01%     
=========================================================
  Files                        412      412              
  Lines                      10977    10986       +9     
  Branches                    1615     1617       +2     
=========================================================
+ Hits                        8795     8802       +7     
  Misses                      1538     1538              
- Partials                     644      646       +2     
Files Coverage Δ
...race/android/embracesdk/injection/SessionModule.kt 100.00% <100.00%> (ø)
...dk/session/orchestrator/SessionOrchestratorImpl.kt 93.69% <90.90%> (+1.07%) ⬆️
...d/embracesdk/session/message/PayloadFactoryImpl.kt 92.50% <82.35%> (-7.50%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from create-payload-module to master March 12, 2024 13:04
@fractalwrench fractalwrench merged commit 033a88b into master Mar 12, 2024
3 checks passed
@fractalwrench fractalwrench deleted the refactor-session-payload branch March 12, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants