Populate additional fields on new payload #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
span-population
branch
from
fd69de0
to
044080c
Compare
fractalwrench
force-pushed
the
remaining-population
branch
from
6680ed8
to
3c4d414
Compare
fractalwrench
force-pushed
the
span-population
branch
from
044080c
to
8d864fc
Compare
fractalwrench
force-pushed
the
remaining-population
branch
from
3c4d414
to
8f1f6f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## span-population #543 +/- ##
===================================================
+ Coverage 79.84% 80.13% +0.28%
===================================================
Files 409 411 +2
Lines 10939 10952 +13
Branches 1615 1615
===================================================
+ Hits 8734 8776 +42
+ Misses 1561 1531 -30
- Partials 644 645 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Populates some additional fields on the new payload (not hooked up to be delivered yet). Specifically I've constructed the log + session payloads & tested they can be generated using fake implementations.
Testing
Added unit test coverage.