Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate spans in new payload #542

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Populate spans in new payload #542

merged 1 commit into from
Mar 12, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Populates spans in the new payload. This isn't hooked up to the orchestrator yet but will allow replacing the old payload when that happens. I've taken the same logic from PayloadMessageCollator for gathering spans & transplanted it here.

Testing

Updated existing test coverage.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.84%. Comparing base (8191745) to head (8d864fc).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
+ Coverage   79.80%   79.84%   +0.03%     
==========================================
  Files         409      409              
  Lines       10933    10939       +6     
  Branches     1614     1615       +1     
==========================================
+ Hits         8725     8734       +9     
+ Misses       1564     1561       -3     
  Partials      644      644              
Files Coverage Δ
...pture/envelope/session/SessionPayloadSourceImpl.kt 91.66% <90.90%> (+8.33%) ⬆️
.../android/embracesdk/internal/payload/SpanMapper.kt 78.94% <87.50%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
You can wait for other reviews if you need to validate payload-specific fields.

@fractalwrench fractalwrench merged commit 98c1673 into master Mar 12, 2024
4 checks passed
@fractalwrench fractalwrench deleted the span-population branch March 12, 2024 13:03
Copy link
Contributor

@priettt priettt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants