Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #532

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix compiler warnings #532

merged 1 commit into from
Mar 11, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Fixes a couple of compiler warnings that were introduced recently.

@fractalwrench fractalwrench requested a review from a team as a code owner March 8, 2024 16:39
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (e3a22db) to head (2eb5735).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   79.47%   79.52%   +0.04%     
==========================================
  Files         403      403              
  Lines       10857    10857              
  Branches     1600     1600              
==========================================
+ Hits         8629     8634       +5     
+ Misses       1583     1580       -3     
+ Partials      645      643       -2     

see 2 files with indirect coverage changes

Copy link
Contributor

@leandro-godon leandro-godon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@fractalwrench fractalwrench merged commit b943585 into master Mar 11, 2024
4 checks passed
@fractalwrench fractalwrench deleted the fix-compiler-warnings branch March 11, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants