Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin populating new session payload #530

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Populates the new session payload with mapping information & internal errors. This is not hooked up to the orchestrator yet so is safe to merge.

Testing

Added unit test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner March 8, 2024 14:50
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.48%. Comparing base (b943585) to head (c555f57).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   79.47%   79.48%           
=======================================
  Files         403      403           
  Lines       10857    10861    +4     
  Branches     1600     1602    +2     
=======================================
+ Hits         8629     8633    +4     
+ Misses       1583     1582    -1     
- Partials      645      646    +1     
Files Coverage Δ
...bracesdk/capture/envelope/SessionEnvelopeSource.kt 100.00% <100.00%> (+33.33%) ⬆️
...pture/envelope/session/SessionPayloadSourceImpl.kt 83.33% <83.33%> (-16.67%) ⬇️

Base automatically changed from add-remaining-payload to master March 8, 2024 15:13
@fractalwrench fractalwrench merged commit 5e18d90 into master Mar 11, 2024
4 checks passed
@fractalwrench fractalwrench deleted the new-session-payload branch March 11, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants