Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EMBR-1230] Make rawPost private in ApiClient #53

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

lucaslabari
Copy link
Contributor

Goal

  • The method postOnExecutor in EmbraceApiService was always being called with a true value for the compress parameter, so postRaw() method was never being called.
  • I removed the if and make rawPost private in ApiClient.

Testing

Updated unit tests.

@lucaslabari lucaslabari requested a review from a team as a code owner November 9, 2023 20:05
Copy link

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #53 (93da3d7) into master (830b97e) will increase coverage by 0.02%.
The diff coverage is 14.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   74.60%   74.63%   +0.02%     
==========================================
  Files         306      306              
  Lines       10082    10078       -4     
  Branches     1454     1453       -1     
==========================================
  Hits         7522     7522              
+ Misses       1980     1976       -4     
  Partials      580      580              
Files Coverage Δ
.../embrace/android/embracesdk/comms/api/ApiClient.kt 64.47% <100.00%> (ø)
...esdk/comms/delivery/EmbraceDeliveryRetryManager.kt 73.97% <ø> (ø)
.../android/embracesdk/comms/api/EmbraceApiService.kt 19.59% <0.00%> (+0.51%) ⬆️

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably revisit this implementation so we gzip the payload before we send it (since it's always compressed anyway) so we can save some room when we store it locally, but that's another PR.

@lucaslabari
Copy link
Contributor Author

@bidetofevil yeap, saving the failed api requests compressed would save storage and will be a great improvement. I'll create a ticket for that.

@lucaslabari lucaslabari merged commit abaccb9 into master Nov 10, 2023
3 of 4 checks passed
@lucaslabari lucaslabari deleted the lucas/embr-1230 branch November 10, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants