Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log payload models #522

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Add log payload models #522

merged 1 commit into from
Mar 8, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds model classes for the new log payloads. This is mostly generated via OpenAPI but tweaked manually for style reasons.

Testing

Added unit test to confirm new model can be constructed from old one.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.44%. Comparing base (5c198c4) to head (68fbe61).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           add-span-payload     #522      +/-   ##
====================================================
+ Coverage             79.42%   79.44%   +0.01%     
====================================================
  Files                   399      403       +4     
  Lines                 10835    10855      +20     
  Branches               1600     1600              
====================================================
+ Hits                   8606     8624      +18     
- Misses                 1583     1586       +3     
+ Partials                646      645       -1     
Files Coverage Δ
...embrace/android/embracesdk/internal/payload/Log.kt 100.00% <100.00%> (ø)
...ace/android/embracesdk/internal/payload/LogBody.kt 100.00% <100.00%> (ø)
...e/android/embracesdk/internal/payload/LogMapper.kt 100.00% <100.00%> (ø)
.../android/embracesdk/internal/payload/LogPayload.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Base automatically changed from add-span-payload to master March 8, 2024 09:24
@fractalwrench fractalwrench merged commit ef3cca9 into master Mar 8, 2024
3 checks passed
@fractalwrench fractalwrench deleted the add-log-payload branch March 8, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants