Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span payload models #520

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Add span payload models #520

merged 1 commit into from
Mar 8, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds model classes for the new span payloads. This is mostly generated via OpenAPI but tweaked manually for style reasons.

Testing

Added unit test to confirm new model can be constructed from old one.

* A key-value pair that provides additional context to the span
*
* @param key The name of the attribute
* @param `value` The value of the attribute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is now called data right?

Base automatically changed from add-internal-err to master March 8, 2024 08:55
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 79.42%. Comparing base (a7b954f) to head (5c198c4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
+ Coverage   79.41%   79.42%   +0.01%     
==========================================
  Files         395      399       +4     
  Lines       10795    10835      +40     
  Branches     1599     1600       +1     
==========================================
+ Hits         8573     8606      +33     
- Misses       1578     1583       +5     
- Partials      644      646       +2     
Files Coverage Δ
...e/android/embracesdk/internal/payload/Attribute.kt 100.00% <100.00%> (ø)
...mbrace/android/embracesdk/internal/payload/Span.kt 100.00% <100.00%> (ø)
...e/android/embracesdk/internal/payload/SpanEvent.kt 100.00% <100.00%> (ø)
.../android/embracesdk/internal/payload/SpanMapper.kt 78.94% <78.94%> (ø)

... and 2 files with indirect coverage changes

@fractalwrench fractalwrench merged commit 9ce2d0b into master Mar 8, 2024
4 checks passed
@fractalwrench fractalwrench deleted the add-span-payload branch March 8, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants