Extract component callbacks from activity service #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 74.60% 74.58% -0.02%
==========================================
Files 306 307 +1
Lines 10082 10094 +12
Branches 1454 1453 -1
==========================================
+ Hits 7522 7529 +7
- Misses 1980 1986 +6
+ Partials 580 579 -1
|
fractalwrench
added a commit
that referenced
this pull request
Nov 10, 2023
Extract component callbacks from activity service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Extracts the component callbacks implementation from the activity service & places it into its own service. This has nothing to do with activities & therefore belongs in a separate file.
Testing
Added unit test coverage.