Extract emb.type to separate source file #518
Conversation
fractalwrench
force-pushed
the
extract-type-names
branch
from
8de9fb4
to
1644d1b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
==========================================
+ Coverage 79.29% 79.33% +0.03%
==========================================
Files 390 391 +1
Lines 10752 10761 +9
Branches 1599 1599
==========================================
+ Hits 8526 8537 +11
+ Misses 1580 1578 -2
Partials 646 646
|
| @@ -0,0 +1,38 @@ | |||
| package io.embrace.android.embracesdk.arch.schema | |||
|
|
|||
| internal object EmbType { | |||
There was a problem hiding this comment.
wouldn't be better to use a Sealed Class in case we need to evaluate the type at some point?
There was a problem hiding this comment.
This is a good point. I was focused on not being able to extend enum classes in Kotlin but forgot sealed classes are an option here. I'll update the PR
| /** | ||
| * Keys that track how fast a time interval is. Only applies to spans. | ||
| */ | ||
| internal enum class Performance : TelemetryType |
There was a problem hiding this comment.
We don't have types and description here... I assume it's going to be added later.
There was a problem hiding this comment.
There are no subtypes now so this is probably fine until we do
| @@ -0,0 +1,38 @@ | |||
| package io.embrace.android.embracesdk.arch.schema | |||
|
|
|||
| internal object EmbType { | |||
There was a problem hiding this comment.
We want the name to be lower-case in the payload - I can't find a way to override name, so I used typeName before. Is there a way to do that so the default enum name would just work?
There was a problem hiding this comment.
I'm not sure I follow. This class doesn't serialize/deserialize JSON, it just holds data that is passed to other classes that do.
fractalwrench
force-pushed
the
extract-type-names
branch
from
1644d1b
to
b4d2c94
Compare
Goal
Extracts the possible values for
emb.typeinto a separate source file. I have organised these as enums implementing a common interface to get a bit of type safety rather than throwing strings around everywhere.#519 also takes this further with a POC for the rest of the strings.