Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build (log service) #513

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

leandro-godon
Copy link
Contributor

Goal

Fixed build from a merge conflict.

@leandro-godon leandro-godon requested a review from a team as a code owner March 6, 2024 17:16
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.35%. Comparing base (22ff1cf) to head (68205d1).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   79.30%   79.35%   +0.04%     
==========================================
  Files         387      387              
  Lines       10545    10563      +18     
  Branches     1571     1571              
==========================================
+ Hits         8363     8382      +19     
+ Misses       1549     1548       -1     
  Partials      633      633              
Files Coverage Δ
.../android/embracesdk/injection/CustomerLogModule.kt 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@leandro-godon leandro-godon merged commit af3a090 into master Mar 6, 2024
4 checks passed
@leandro-godon leandro-godon deleted the leandro/fix_master_log_service branch March 6, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants