Additional EmbraceUrlConnectionDelegate unit tests and bug fixes #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
bidetofevil
force-pushed
the
hho/moar-network-tests
branch
2 times, most recently
from
b16e8ba
to
115affb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 73.47% 74.60% +1.13%
==========================================
Files 306 306
Lines 10070 10082 +12
Branches 1448 1454 +6
==========================================
+ Hits 7399 7522 +123
+ Misses 2103 1980 -123
- Partials 568 580 +12
|
bidetofevil
force-pushed
the
hho/moar-network-tests
branch
from
115affb
to
3d53364
Compare
bidetofevil
force-pushed
the
hho/moar-network-tests
branch
from
8de4c9f
to
c78bdc8
Compare
nelsitoPuglisi
approved these changes
Nov 8, 2023
| @@ -28,7 +28,7 @@ public String getHeaderByName(@NonNull String name) { | |||
| public String getOverriddenURL(@NonNull String pathOverride) { | |||
| try { | |||
| return new URL(connection.getURL().getProtocol(), connection.getURL().getHost(), | |||
| connection.getURL().getPort(), pathOverride).toString(); | |||
| connection.getURL().getPort(), pathOverride + "?" + connection.getURL().getQuery()).toString(); | |||
There was a problem hiding this comment.
What's the purpose of this change? Is it because we were discarding the query params?
There was a problem hiding this comment.
Yeah. This is the bug I mention in the second bullet point in the PR description. When you toString() a URL, it includes the query path as part of the returned string. When we return teh URL with an overridden path, we should do the same. (This is what the OkHttp implementation does)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add additional unit tests for more cases for logging URLConnection requests and fix a few issues that were found. Specifically:
Testing
Add unit tests of important cases where breakage may not be obvious