Add fragment breadcrumb data source #491
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
==========================================
- Coverage 79.33% 79.29% -0.04%
==========================================
Files 389 390 +1
Lines 10722 10752 +30
Branches 1594 1599 +5
==========================================
+ Hits 8506 8526 +20
- Misses 1577 1580 +3
- Partials 639 646 +7
|
fractalwrench
force-pushed
the
add-view-crumb-spans
branch
2 times, most recently
from
e88aec2
to
6a61b7d
Compare
|
|
||
| @Test | ||
| fun `end an unknown fragment`() { | ||
| dataSource.endFragment("my_fragment") |
There was a problem hiding this comment.
It might be good to validate that this returns false.
There was a problem hiding this comment.
Added an extra assertion here
| * by [RemoteConfig]. | ||
| */ | ||
| private const val DEFAULT_VIEW_STACK_SIZE = 20 | ||
| internal const val TYPE_NAME = "ux.view" |
There was a problem hiding this comment.
defining these in each data source is really calling out for a central repository now 😅
There was a problem hiding this comment.
Will address this in a separate PR
| /** | ||
| * Captures fragment breadcrumbs. | ||
| */ | ||
| internal class LegacyFragmentBreadcrumbDataSource( |
There was a problem hiding this comment.
The functionality of the legacy services are validated by... the integration tests?
There was a problem hiding this comment.
If there's existing test coverage yes. I think this one is covered by existing unit test coverage.
fractalwrench
force-pushed
the
add-view-crumb-spans
branch
from
6a61b7d
to
3242f45
Compare
Goal
Implements the capture of fragment breadcrumbs via the
DataSourceinterface which allows them to be sent as OTel spans in the session payload. It's important to note this does not alter the session payload yet. TheLegacyFragmentBreadcrumbDataSourcewill continue to add directly to the payload.A future PR will contain the changeset for enabling the new data capture mechanism. This uncouples work & allows us to merge more without blocking changes.
Testing
Added a unit test.