Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom breadcrumb data source #487

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Mar 4, 2024

Goal

Implements the capture of custom breadcrumbs via the DataSource interface which allows them to be sent as OTel data types in the session payload. It's important to note this does not alter the session payload yet. The LegacyCustomBreadcrumbDataSource will continue to add directly to the payload.

#488 contains the changeset for enabling the new data capture mechanism. This uncouples work & allows us to merge more without blocking changes.

Testing

Added a unit test.

@fractalwrench fractalwrench force-pushed the add-custom-breadcrumb-data-source branch from 8786b31 to a01f6fb Compare March 4, 2024 11:22
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 79.34%. Comparing base (026492f) to head (4ff32a8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage   79.31%   79.34%   +0.03%     
==========================================
  Files         387      388       +1     
  Lines       10561    10577      +16     
  Branches     1571     1573       +2     
==========================================
+ Hits         8376     8392      +16     
  Misses       1551     1551              
  Partials      634      634              
Files Coverage Δ
...racesdk/capture/crumbs/EmbraceBreadcrumbService.kt 96.55% <100.00%> (ø)
...cesdk/capture/crumbs/CustomBreadcrumbDataSource.kt 93.75% <93.33%> (+43.75%) ⬆️
...capture/crumbs/LegacyCustomBreadcrumbDataSource.kt 50.00% <50.00%> (ø)

... and 2 files with indirect coverage changes

@fractalwrench fractalwrench force-pushed the add-custom-breadcrumb-data-source branch 2 times, most recently from a98d72d to be1b288 Compare March 6, 2024 10:53
@fractalwrench fractalwrench marked this pull request as ready for review March 6, 2024 10:54
@fractalwrench fractalwrench requested a review from a team as a code owner March 6, 2024 10:54
Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the add-custom-breadcrumb-data-source branch from be1b288 to 4ff32a8 Compare March 7, 2024 09:29
@fractalwrench fractalwrench merged commit 4e21f52 into master Mar 7, 2024
4 checks passed
@fractalwrench fractalwrench deleted the add-custom-breadcrumb-data-source branch March 7, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants