Initialize the new log service #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/injection/CustomerLogModule.kt
Outdated
Show resolved
Hide resolved
fractalwrench
approved these changes
Mar 1, 2024
| @@ -63,4 +69,23 @@ internal class CustomerLogModuleImpl( | |||
| workerThreadModule.backgroundWorker(WorkerName.REMOTE_LOGGING) | |||
| ) | |||
| } | |||
|
|
|||
| override val logService: LogService by singleton { | |||
There was a problem hiding this comment.
I think we might need to initialize this in the OpenTelemetryModule instead as it will be used for initializing other data capture sources.
There was a problem hiding this comment.
I don't think the LogService needs to be used by other data sources, since it deals with Embrace logs only. Other sources can use the LogWriter which is initialized in the OpenTelemetryModule. On the other hand, LogOrchestrator might need to be moved, although its dependency on DeliveryService can complicate things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add LogService and LogOrchestrator to the Log module so they can be used within the SDK.