Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename to use Span instead of Spans in the names of things #426

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Rename to use Span instead of Spans in the names of things #426

merged 1 commit into from
Feb 16, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Feb 15, 2024 •
edited
Loading

Goal

Big rename to change Spans* to Span*

@bidetofevil Graphite App
Copy link
Collaborator Author

bidetofevil commented Feb 15, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@bidetofevil bidetofevil mentioned this pull request Feb 15, 2024
Merged
This was referenced Feb 16, 2024
Merged
Merged
@bidetofevil bidetofevil marked this pull request as ready for review February 16, 2024 08:14
@bidetofevil bidetofevil requested a review from a team as a code owner February 16, 2024 08:14
fractalwrench
fractalwrench approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil Graphite App
Copy link
Collaborator Author

bidetofevil commented Feb 16, 2024 •
edited
Loading

Merge activity

  • Feb 16, 12:07 PM EST: @bidetofevil started a stack merge that includes this pull request via Graphite.
  • Feb 16, 12:08 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 16, 12:09 PM EST: @bidetofevil merged this pull request with Graphite.

Base automatically changed from hho/update-otel-1.35 to master February 16, 2024 17:07
@bidetofevil bidetofevil merged commit 934a05b into master Feb 16, 2024
3 checks passed
@bidetofevil bidetofevil deleted the hho/spansservice-rename branch February 16, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalwrench fractalwrench fractalwrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bidetofevil @fractalwrench