Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public internal things from public docs generated by Dokka #42

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Nov 1, 2023

Goal

Add the Android Dokka plugin so we can use @hide to suppress Java things, which @suppress won't work for as it's a KDoc thing.

Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #42 (808e50b) into master (a03129f) will increase coverage by 0.15%.
Report is 23 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   73.61%   73.76%   +0.15%     
==========================================
  Files         305      305              
  Lines       10041    10053      +12     
  Branches     1446     1447       +1     
==========================================
+ Hits         7392     7416      +24     
+ Misses       2077     2067      -10     
+ Partials      572      570       -2     
Files Coverage Δ
...in/java/io/embrace/android/embracesdk/Embrace.java 48.86% <ø> (ø)
...va/io/embrace/android/embracesdk/EmbraceSamples.kt 0.00% <ø> (ø)
.../io/embrace/android/embracesdk/LogExceptionType.kt 100.00% <ø> (ø)
.../embrace/android/embracesdk/ViewSwazzledHooks.java 0.00% <ø> (ø)
...d/embracesdk/WebViewChromeClientSwazzledHooks.java 0.00% <ø> (ø)
...android/embracesdk/WebViewClientSwazzledHooks.java 100.00% <ø> (ø)
...ndroid/embracesdk/config/behavior/SpansBehavior.kt 100.00% <ø> (ø)
...roid/embracesdk/config/remote/SpansRemoteConfig.kt 100.00% <ø> (ø)
...a/io/embrace/android/embracesdk/payload/Session.kt 100.00% <ø> (ø)

... and 13 files with indirect coverage changes

@bidetofevil bidetofevil marked this pull request as ready for review November 1, 2023 22:29
@bidetofevil bidetofevil requested review from fnewberg and a team as code owners November 1, 2023 22:29
@bidetofevil bidetofevil merged commit 1ee3ec3 into master Nov 2, 2023
4 checks passed
@bidetofevil bidetofevil deleted the hho/remove-internals-from-docs branch November 2, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants