Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tracing interface internal #40

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Make tracing interface internal #40

merged 1 commit into from
Nov 1, 2023

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Nov 1, 2023 •
edited

Goal

The interface file didn't need to be public as they are implemented in Embrace.java already

@bidetofevil Graphite App
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Nov 1, 2023
Merged
Merged
@bidetofevil bidetofevil marked this pull request as ready for review November 1, 2023 06:46
@bidetofevil Graphite App
Copy link
Collaborator Author

bidetofevil commented Nov 1, 2023 •
edited

Merge activity

Base automatically changed from hho/move-annotations to master November 1, 2023 16:05
@bidetofevil bidetofevil merged commit 7114eb0 into master Nov 1, 2023
3 checks passed
@bidetofevil bidetofevil deleted the hho/make-tracing-interface-internal branch November 1, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsitoPuglisi nelsitoPuglisi nelsitoPuglisi approved these changes

@fractalwrench fractalwrench Awaiting requested review from fractalwrench fractalwrench is a code owner

@fnewberg fnewberg Awaiting requested review from fnewberg fnewberg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bidetofevil @nelsitoPuglisi