Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addSpanExporter api #377

Merged
merged 37 commits into from
Feb 9, 2024
Merged

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented Feb 7, 2024

Goal

Adds a public api that allows a client app to add a SpanExporter at runtime, through a OpenTelemetryConfiguration class.

Testing

Added instrumentation tests to SpanTests class.

Release Notes

New addSpanExporter public api, to add many SpanExporters to the OTel SDK.

WHAT:We have created an api to add SpanExporters to the OTel SDK
WHY:To allow customers to export their data to any OTel Collector.
WHO:Any customer with an OTel collector.

Copy link
Contributor Author

nelsitoPuglisi commented Feb 7, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/otel-exporter-add-span-exporter branch 2 times, most recently from 5cfce20 to 1eda48e Compare February 7, 2024 18:48
@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/otel-exporter-add-span-exporter branch from 1eda48e to 05b8f3e Compare February 8, 2024 11:28
@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/otel-exporter-add-span-exporter branch from 05b8f3e to ab17d1d Compare February 8, 2024 16:39
@nelsitoPuglisi nelsitoPuglisi changed the base branch from nelson/otel-exporter-composite to nelson/otel-add-resource February 8, 2024 17:31
@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/otel-exporter-add-span-exporter branch from ab17d1d to c7df7d9 Compare February 8, 2024 17:31
@nelsitoPuglisi nelsitoPuglisi force-pushed the nelson/otel-exporter-add-span-exporter branch from c7df7d9 to ef6d0fb Compare February 8, 2024 20:32
@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review February 8, 2024 20:35
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (44428e8) 79.00% compared to head (9ec1dca) 79.05%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   79.00%   79.05%   +0.04%     
==========================================
  Files         350      351       +1     
  Lines        9731     9744      +13     
  Branches     1453     1454       +1     
==========================================
+ Hits         7688     7703      +15     
+ Misses       1462     1459       -3     
- Partials      581      582       +1     
Files Coverage Δ
...ava/io/embrace/android/embracesdk/EmbraceImpl.java 57.97% <100.00%> (+0.11%) ⬆️
...ndroid/embracesdk/injection/OpenTelemetryModule.kt 100.00% <100.00%> (ø)
...acesdk/opentelemetry/OpenTelemetryConfiguration.kt 100.00% <100.00%> (ø)
...droid/embracesdk/opentelemetry/OpenTelemetrySdk.kt 88.23% <100.00%> (ø)
...in/java/io/embrace/android/embracesdk/Embrace.java 54.21% <50.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

Base automatically changed from nelson/otel-add-resource to master February 9, 2024 18:33
@nelsitoPuglisi nelsitoPuglisi merged commit b02fb38 into master Feb 9, 2024
5 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/otel-exporter-add-span-exporter branch February 9, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants