-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addSpanExporter api #377
Merged
nelsitoPuglisi
merged 37 commits into
master
from
nelson/otel-exporter-add-span-exporter
Feb 9, 2024
Merged
addSpanExporter api #377
nelsitoPuglisi
merged 37 commits into
master
from
nelson/otel-exporter-add-span-exporter
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2024
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
5cfce20
to
1eda48e
Compare
bidetofevil
reviewed
Feb 7, 2024
embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/injection/InitModule.kt
Outdated
Show resolved
Hide resolved
embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/Embrace.java
Outdated
Show resolved
Hide resolved
e10bbb5
to
3d88cba
Compare
1eda48e
to
05b8f3e
Compare
3d88cba
to
18d92fd
Compare
05b8f3e
to
ab17d1d
Compare
ab17d1d
to
c7df7d9
Compare
bidetofevil
reviewed
Feb 8, 2024
embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/Embrace.java
Outdated
Show resolved
Hide resolved
...ace-android-sdk/src/main/java/io/embrace/android/embracesdk/injection/OpenTelemetryModule.kt
Outdated
Show resolved
Hide resolved
c7df7d9
to
ef6d0fb
Compare
bidetofevil
reviewed
Feb 8, 2024
...e-android-sdk/src/integrationTest/kotlin/io/embrace/android/embracesdk/testcases/SpanTest.kt
Outdated
Show resolved
Hide resolved
…k/EmbraceApi.java Co-authored-by: Jamie Lynch <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
==========================================
+ Coverage 79.00% 79.05% +0.04%
==========================================
Files 350 351 +1
Lines 9731 9744 +13
Branches 1453 1454 +1
==========================================
+ Hits 7688 7703 +15
+ Misses 1462 1459 -3
- Partials 581 582 +1
|
4b73098
to
1b45ccd
Compare
# Conflicts: # embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/opentelemetry/OpenTelemetrySdk.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds a public api that allows a client app to add a SpanExporter at runtime, through a OpenTelemetryConfiguration class.
Testing
Added instrumentation tests to
SpanTests
class.Release Notes
New
addSpanExporter
public api, to add many SpanExporters to the OTel SDK.WHAT:We have created an api to add SpanExporters to the OTel SDK
WHY:To allow customers to export their data to any OTel Collector.
WHO:Any customer with an OTel collector.