Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release branch to build release #338

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Feb 1, 2024

Goal

Modify release workflows to create a release branch on which release specific changes will be made. Added a test workflow to test the branch creation to verify that it will actually work.

Copy link
Collaborator Author

bidetofevil commented Feb 1, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@bidetofevil bidetofevil marked this pull request as ready for review February 1, 2024 00:58
@bidetofevil bidetofevil requested a review from a team as a code owner February 1, 2024 00:58
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a09505) 77.38% compared to head (a332558) 77.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   77.38%   77.45%   +0.07%     
==========================================
  Files         340      340              
  Lines        9966     9966              
  Branches     1464     1464              
==========================================
+ Hits         7712     7719       +7     
+ Misses       1676     1667       -9     
- Partials      578      580       +2     

see 4 files with indirect coverage changes

@bidetofevil bidetofevil force-pushed the hho/release-on-release-branch branch 2 times, most recently from 5d03ac4 to ec26fc0 Compare February 2, 2024 00:44
@bidetofevil bidetofevil mentioned this pull request Feb 2, 2024
Copy link
Collaborator

@cesarmax22 cesarmax22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks promising. I like it.

@bidetofevil bidetofevil merged commit d6e8e59 into master Feb 2, 2024
7 checks passed
@bidetofevil bidetofevil deleted the hho/release-on-release-branch branch February 2, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants