Only rebuild response in OkHttp interceptor if we modify the body #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Oct 27, 2023
bidetofevil
commented
Oct 29, 2023
| @@ -132,6 +120,40 @@ public class EmbraceOkHttp3NetworkInterceptor internal constructor( | |||
| return response | |||
| } | |||
|
|
|||
| private fun getContentLengthFromHeader(networkResponse: Response): Long? { | |||
There was a problem hiding this comment.
These methods were pulled out of intercept to make it easier to read. No change logic was made along with the move other than contentType now being read form the headers as needed rather the always read and stored in a variable (it is probably never actually read twice anyway since most responses come with a content-length header and we don't typically need to grab it from the body)
bidetofevil
force-pushed
the
hho/okhttp-interceptor
branch
from
5446ba6
to
0dc00ad
Compare
bidetofevil
force-pushed
the
hho/okhttp-interceptor
branch
from
0dc00ad
to
6be995f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We were rebuilding the response even if we didn't change it, which is unnecessary work. As such, this change simply bypasses and reuses the response that we get initially from calling
chain.proceed(request)Testing
Existing tests pass