Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log how many times a signal handler was invoked #31

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

fractalwrench
Copy link
Contributor

Goal

Logs a message of how many times the signal handler was invoked when processing a native crash. This will help us rule out the theory that a signal handler being invoked multiple times causes problems in stacktrace quality. This information was actually already being recorded but wasn't being used.

@fractalwrench fractalwrench requested a review from a team as a code owner October 27, 2023 13:28
Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 86729e7 into master Oct 27, 2023
4 checks passed
@fractalwrench fractalwrench deleted the record-sig-handler-count branch October 27, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants