Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move functional tests #187

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Move functional tests #187

merged 1 commit into from
Dec 15, 2023

Conversation

fractalwrench
Copy link
Contributor

Goal

Moves the functional tests to androidTest of the main SDK module. This allows them to access internally visible code etc that previously required abusing Java's package-private visiblity.

@fractalwrench fractalwrench requested a review from a team as a code owner December 15, 2023 15:30
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #187 (3fdee9b) into master (b7f4bca) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   76.22%   76.24%   +0.02%     
==========================================
  Files         319      319              
  Lines        9947     9947              
  Branches     1459     1459              
==========================================
+ Hits         7582     7584       +2     
+ Misses       1792     1789       -3     
- Partials      573      574       +1     

see 2 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE. Since all the deps are declared as testImplementation, this shouldn't affect the binary we ship at all right?

BTW, we should probably extract all the other versions out of here so we can keep them consistent and in the same place Another patch of course.

@fractalwrench
Copy link
Contributor Author

Yep - this shouldn't affect the binary that is shipped at all.

@fractalwrench fractalwrench merged commit 0a9d88f into master Dec 15, 2023
4 checks passed
@fractalwrench fractalwrench deleted the move-func-tests branch December 15, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants