Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace null assertions with checkNotNull #138

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

fractalwrench
Copy link
Contributor

Goal

Replaces some existing null assertions with checkNotNull(), which is a bit more explicit IMO that a NPE is not expected.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner November 28, 2023 16:18
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #138 (0dd59b1) into master (1258907) will increase coverage by 0.01%.
The diff coverage is 37.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   76.12%   76.14%   +0.01%     
==========================================
  Files         318      318              
  Lines       10117    10121       +4     
  Branches     1484     1486       +2     
==========================================
+ Hits         7702     7707       +5     
+ Misses       1812     1809       -3     
- Partials      603      605       +2     
Files Coverage Δ
...mbracesdk/capture/webview/EmbraceWebViewService.kt 79.16% <0.00%> (-2.09%) ⬇️
...racesdk/capture/crumbs/EmbraceBreadcrumbService.kt 74.70% <33.33%> (-0.20%) ⬇️
...roid/embracesdk/ndk/EmbraceNdkServiceRepository.kt 71.69% <50.00%> (+1.10%) ⬆️

... and 1 file with indirect coverage changes

@fractalwrench fractalwrench merged commit b24e31d into master Nov 29, 2023
3 of 4 checks passed
@fractalwrench fractalwrench deleted the refactor-null-checks branch November 29, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants