Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support app startup initialization #1063

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Support app startup initialization #1063

merged 1 commit into from
Jul 16, 2024

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Jul 8, 2024

Goal

Initializes the SDK using the App Startup library rather than manual invocation. This happens earlier in the process lifecycle & requires less manual intervention from a user during the integration process.

Testing

Manually tested via our test app.

Copy link

github-actions bot commented Jul 8, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.70%. Comparing base (0bb5f97) to head (28a5c2e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
- Coverage   79.74%   79.70%   -0.05%     
==========================================
  Files         425      426       +1     
  Lines       10794    10799       +5     
  Branches     1769     1769              
==========================================
- Hits         8608     8607       -1     
- Misses       1401     1406       +5     
- Partials      785      786       +1     
Files Coverage Δ
...roid/embracesdk/internal/EmbraceCoreInitializer.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@fractalwrench fractalwrench force-pushed the app-startup branch 3 times, most recently from 917f78f to 1625a09 Compare July 12, 2024 09:08
@fractalwrench fractalwrench marked this pull request as ready for review July 12, 2024 09:08
@fractalwrench fractalwrench requested a review from a team as a code owner July 12, 2024 09:08
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 1222bac into master Jul 16, 2024
4 of 5 checks passed
@fractalwrench fractalwrench deleted the app-startup branch July 16, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants